test: add regression test for issue #2001 (progress related_request_id)#2747
Open
kaushik701 wants to merge 4 commits into
Open
test: add regression test for issue #2001 (progress related_request_id)#2747kaushik701 wants to merge 4 commits into
kaushik701 wants to merge 4 commits into
Conversation
…ss related_request_id) Adds a dedicated regression test file for issue modelcontextprotocol#2001. Context.report_progress() was silently dropping progress notifications in stateless HTTP / SSE transports because send_progress_notification() was called without related_request_id. The fix (already in main via mcpserver/context.py) passes related_request_id=self.request_id, consistent with send_log_message(). This test file covers: - The primary regression: related_request_id is forwarded on every call - Edge case: no progress_token -> notification is skipped (no-op) - Edge case: integer progress_token (e.g. 0) works correctly Closes modelcontextprotocol#2001
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a dedicated regression test file for issue #2001.
Context.report_progress() was silently dropping progress notifications in stateless HTTP / SSE transports because send_progress_notification() was called without related_request_id. The fix (already in main via mcpserver/context.py) passes related_request_id=self.request_id, consistent with send_log_message().
This test file covers:
Closes #2001
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context